Ruby: Connect system port in Ruby network test

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Ruby: Connect system port in Ruby network test

This patch connects the system port and thereby allows the failing
Ruby test (and other Ruby systems) to run again.

Testing Done

Can you check if other scripts need to be fixed as well?

Description:

		Ruby: Connect system port in Ruby network test

~		This patch connects the system port in the Ruby network test, and thus
~		allows it to run again.
	~	This patch connects the system port and thereby allows the failing
	~	Ruby test (and other Ruby systems) to run again.

Diff:

Revision 2 (+19 -1)

Show changes

	configs/example/ruby_direct_test.py
	configs/example/ruby_mem_test.py
	configs/example/ruby_network_test.py
	configs/example/ruby_random_test.py
	tests/configs/o3-timing-mp-ruby.py
	tests/configs/o3-timing-ruby.py
	tests/configs/simple-atomic-mp-ruby.py

Diff:

Revision 3 (+21)

Show changes

	configs/example/ruby_direct_test.py
	configs/example/ruby_mem_test.py
	configs/example/ruby_network_test.py
	configs/example/ruby_random_test.py
	tests/configs/o3-timing-mp-ruby.py
	tests/configs/o3-timing-ruby.py
	tests/configs/simple-atomic-mp-ruby.py

Andreas, can include this line in the function create_system()
in Ruby.py in configs/ruby? I think that will cover all the
Ruby related scripts, though I am not aware of the order in
which things should happen.

Andreas Hansson Jan. 29, 2012, 3:20 a.m. (Jan. 29, 2012, 3:20 a.m.)

I've followed your suggestion and it will be part of tonight's regression. One thing that struck me is that some script, e.g. o3-timing-ruby and simple-atomic-ruby do not use create_system but rather Ruby.generate. There do not seem to be any tests running these scripts though.

I'll post an update once the regressions pass.

Andreas Hansson Jan. 29, 2012, 10:23 p.m. (Jan. 29, 2012, 10:23 p.m.)
```
util/regress passes for all (excluding t1000 and eio)
```
Nilay Vaish Jan. 29, 2012, 10:29 p.m. (Jan. 29, 2012, 10:29 p.m.)
```
Commit it!
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Diff:

Diff:

Status: Closed (submitted)