request: added split Paddr function
Review Request #1128 - Created April 4, 2012 and discarded
Changeset 8930:1aab533823f3 --------------------------- request: added split Paddr function
2 1 1 0
|Seems like we should just use the default copy constructor here: req1 = new Request(*this); req2 = new Request(*this); Looks ...||Steve Reinhardt||April 5, 2012, 5:47 a.m.||Open|
Posted (April 4, 2012, 7:31 p.m.)
src/mem/request.hh (Diff revision 1)
Perhaps be a bit more verbose to please Doxygen
Review request changed
Updated (April 5, 2012, 5:22 a.m.)
Revision 2 (+18)
Posted (April 5, 2012, 5:47 a.m.)
Where/when is this used? It seems kind of odd to add a new method and not add any use cases. I can see where support for cache-line-crossing accesses could use this, but only if that's done post-translation (otherwise splitOnVaddr() would be sufficient). Someone going back and trying to clean things up would be tempted to get rid of this as dead code. If there's a separate patch coming that actually uses this method, I'd prefer to see those patches merged. If not, something in the comment explaining when/where this is needed would be useful.
src/mem/request.hh (Diff revision 2)
Seems like we should just use the default copy constructor here: req1 = new Request(*this); req2 = new Request(*this); Looks like you just copied splitOnVaddr(), so this issue should be fixed there too.