python: added __nonzero__ function to SimObject Bool params | Review Request

Information
Submitter:	Brad Beckmann
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 8931:ff280a178bdf
---------------------------
python: added __nonzero__ function to SimObject Bool params

Testing Done

Issue Summary

Description	From	Last Updated	Status
Why not use getValue()?	Andreas Hansson	April 5, 2012, 5:16 a.m.	Dropped

src/python/m5/params.py (Diff revision 1)

Why not use getValue()?

Show all issues

Brad Beckmann April 5, 2012, 5:16 a.m. (April 5, 2012, 5:16 a.m.)

I could, but adding the "__nonzero__" function makes things much more readable.  More importantly this patches fixes the bug where currently testing a bool prameter always evaluates to be true.  Without this change, the following code from review #1126 would not work correctly:

     if ruby_port.support_data_reqs: 
          tester.cpuDataPort = ruby_port.slave 
     if ruby_port.support_inst_reqs: 
          tester.cpuInstPort = ruby_port.slave

A comment along the lines of what you mentioned in the review discussion would be good.

Brad Beckmann April 5, 2012, 7:57 a.m. (April 5, 2012, 7:57 a.m.)
```
Done. 
```

Description:

~		Changeset 8931:ee5f54ce4140
	~	Changeset 8931:ff280a178bdf

		python: added nonzero function to SimObject Bool params

Diff:

Revision 2 (+5)

Show changes

src/python/m5/params.py

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

python: added nonzero function to SimObject Bool params

Screenshots

Files

Issue Summary

Description:

Changeset 8931:ee5f54ce4140

Changeset 8931:ff280a178bdf

Diff:

Status: Closed (submitted)