Review Board 2.0.15


Make TRIPS binaries available

Review Request #16 - Created April 28, 2010 and updated

Information
Gou Pengfei
gem5
Reviewers
Default
ali, nate 
Some trivial changes.
Can load binaries generated by TRIPS toolchain.
Gabe Black
Posted (April 29, 2010, 5:37 p.m.)
This change is pretty close to ok. If you fix up the things mentioned below, it should be ready to go. I'd want to look at it one last time to be sure, though.
src/base/loader/elf_object.cc (Diff revision 1) 
 
 
 
Remove this comment.
src/base/loader/elf_object.cc (Diff revision 1) 
 
 
 
This change is unnecessary and actually breaks M5 style guidelines.
src/base/loader/elf_object.cc (Diff revision 1) 
 
 
 
I don't think you need to change the whitespace here.
src/base/loader/object_file.hh (Diff revision 1) 
 
 
 
Remove this comment.
Gabe Black
Posted (April 29, 2010, 5:50 p.m.)



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/base/loader/elf_object.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
You need brackets here.