Review Board 2.0.15

base: Clean up signal handling

Review Request #2035 - Created Oct. 7, 2013 and submitted

Andreas Sandberg
Changeset 9906:a64f74eb0d5a
base: Clean up signal handling

The PollEvent class dynamically installs a SIGIO and SIGALRM handler
when a file handler is registered. Most signal handlers currently get
registered in the initSignals() function. This changeset moves the
SIGIO/SIGALRM handlers to initSignals() to live with the other signal
handlers. The original code installs SIGIO and SIGALRM with the
SA_RESTART option to prevent syscalls from returning EINTR. This
changeset consistently uses this flag for all signal handlers to
ensure that other signals that trigger asynchronous behavior (e.g.,
statistics dumping) do not cause undesirable EINTR returns.
Ran on x86 with KVM. Verified that asynchronous sockets work (terminal).
Review request changed
Updated (Nov. 29, 2013, 6:06 a.m.)

Status: Closed (submitted)