arch: Properly guess OpClass from optional StaticInst flags
Review Request #2294 - Created June 12, 2014 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10249:73d1e7e4bfff --------------------------- arch: Properly guess OpClass from optional StaticInst flags isa_parser.py guesses the OpClass if none were given based upon the StaticInst flags. The existing code does not take into account optionally set flags. This code hoists the setting of optional flags so OpClass is properly assigned.
Minor comment below is just optional.
-
src/arch/isa_parser.py (Diff revision 1) -
Not a big deal, but I'd use None rather than the empty string here to make it clear that it's unset. Could even skip this line entirely and use "hasattr(self, 'op_class')" below, but that's overkill IMO.