arm: support 16kb vm granules
Review Request #2327 - Created Aug. 13, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10303:d7a21596221d --------------------------- arm: support 16kb vm granules
Posted (Aug. 15, 2014, 8:08 p.m.)
-
src/arch/arm/table_walker.hh (Diff revision 1) -
Why not map these to 12, 14 and 16? This will eliminate the separate int grainSize variable that is being maintained. To me it seems only one of grain and grainsize is required.
-
src/arch/arm/table_walker.cc (Diff revision 1) -
GrainSize instead of unsigned.
Review request changed
Updated (Aug. 18, 2014, 2:55 p.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+127 -66) |
Posted (Aug. 20, 2014, 10:39 a.m.)
While I am ok with the changes made, do you think it is possible to retain the Enum instead of using 12, 14 and 16?
Review request changed
Updated (Aug. 26, 2014, 2:04 p.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+139 -68) |