style: Add support for a style ignore list and ignore ext/
Review Request #2331 - Created Aug. 13, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10291:522c461fc667 --------------------------- style: Add support for a style ignore list and ignore ext/ There are some directories within the repository where we don't want to enforce our coding style. Specifically, we don't want the style hooks to warn whenever we update external code in the ext/ directory.
Overall I am fine with the patch. Somehow I do not like the option name 'no-ignore'. How about 'ignore-ignore-list' or 'no-ignore-list' or 'avoid-ignore-list'? Secondly, don't you think there is some conflict between this option and the --all option? Would it make sense to rename the --all option to something like --check-clean-modified-files?