mem: Refactor assignment of Packet types
Review Request #2339 - Created Aug. 13, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10306:8de97ea1af30 --------------------------- mem: Refactor assignment of Packet types Put the packet type swizzling (that is currently done in a lot of places) into a refineCommand() member function.
Ship It!
Posted (Aug. 18, 2014, 2:28 p.m.)
This looks like a step in the right direction, but how about taking another step and just embedding all this logic in the Packet constructor? That seems like it would be even cleaner from the caller's perspective. If necessary, we could use an additional constructor flag or an alternate constructor to provide a path to set the memory command which would not get refined.