mem: Multi Level Page Table bug fix

Information
Submitter:	Alexandru Dutu
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10424:853fff736800
---------------------------
mem: Multi Level Page Table bug fix

The multi level page table was giving false positives for already mapped
translations. This patch fixes the bogus behavior.

Testing Done

Quick regressions passed.

Issue Summary

Description	From	Last Updated	Status
Is fatal really suitable here? Is it a user error, or should it rather be a panic?	Andreas Hansson	Oct. 13, 2014, 8:47 p.m.	Resolved

Should this not be folded into the original patch?

Alexandru Dutu Sept. 30, 2014, 1:41 p.m. (Sept. 30, 2014, 1:41 p.m.)

I am not sure, that patch has already been commited. I thought once commited, a patch becomes a commit and one can't modify it.

Andreas Hansson Sept. 30, 2014, 1:42 p.m. (Sept. 30, 2014, 1:42 p.m.)
```
My bad.
```

Steve Reinhardt Sept. 30, 2014, 1:43 p.m. (Sept. 30, 2014, 1:43 p.m.)

This is exactly what I asked Alex when he posted this internally... then he pointed out that the original patch has already been committed:
http://repo.gem5.org/gem5/rev/77af86f37337

src/mem/multi_level_page_table_impl.hh (Diff revision 1)

Is fatal really suitable here? Is it a user error, or should it rather be a panic?

Show all issues

Alexandru Dutu Sept. 30, 2014, 1:56 p.m. (Sept. 30, 2014, 1:56 p.m.)

I interpret this as the user is trying to map something already mapped. I am considerring this a user fault as pages can be mapped from python scripts, however the C++ part of the simulator can call this method in which case it should be a panic. So the borderline for panic and fatal is a bit blurry for me in this case.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)