mem: Add const getters for write packet data

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10564:75153948fe34
---------------------------
mem: Add const getters for write packet data

This patch takes a first step in tightening up how we use the data
pointer in write packets. A const getter is added for the pointer
itself (getConstPtr), and a number of member functions are also made
const accordingly. In a range of places throughout the memory system
the new member is used.

The patch also removes the unused isReadWrite function.

Testing Done

Issue Summary

Description	From	Last Updated	Status
I think we can keep the function name as getPtr() and rely on the compiler to pick the right version. ...	Nilay Vaish	Nov. 18, 2014, 11:03 a.m.	Dropped

src/mem/packet.hh (Diff revision 1)

I think we can keep the function name as getPtr() and rely on the compiler to pick the right version.  Also how about const_cast<T*> instead of C style casting?

Show all issues

Andreas Hansson Nov. 18, 2014, 8:19 a.m. (Nov. 18, 2014, 8:19 a.m.)

I'd actually prefer it to be explicit at this point if you don't mind. I has helped me figure out where we should be using const but cannot due to the way read/write is part of the same function, but with a bool is_read (which is currently done in a lot of devices for example).

Nilay Vaish Nov. 18, 2014, 8:58 a.m. (Nov. 18, 2014, 8:58 a.m.)
```
As you like it.
```

Ship It!

Looks good other than minor commit message update; no need to repost.

src/mem/packet.hh (Diff revision 1)

I take it this (& the corresponding Packet version below) is being dropped because it's unused?  Fine with me, but it would be good to mention that in the commit message.

Andreas Hansson Nov. 30, 2014, 1:32 a.m. (Nov. 30, 2014, 1:32 a.m.)
```
I've added a line.
```

Description:

~		Changeset 10541:d68e4d58597b
	~	Changeset 10564:75153948fe34

		mem: Add const getters for write packet data

		This patch takes a first step in tightening up how we use the data
		pointer in write packets. A const getter is added for the pointer
		itself (getConstPtr), and a number of member functions are also made
		const accordingly. In a range of places throughout the memory system
		the new member is used.
	+
	+	The patch also removes the unused isReadWrite function.

Diff:

Revision 2 (+49 -41)

Show changes

	src/cpu/inorder/resources/cache_unit.cc
	src/cpu/inorder/resources/fetch_unit.cc
	src/cpu/minor/execute.cc
	src/cpu/minor/lsq.cc
	src/cpu/o3/fetch_impl.hh
	src/cpu/simple/atomic.cc
	src/cpu/testers/memtest/memtest.cc
	src/cpu/testers/rubytest/Check.cc
	12 more

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 10541:d68e4d58597b

Changeset 10564:75153948fe34

Diff:

Status: Closed (submitted)