mem: Use const pointers for port proxy write functions

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10542:6cbdd036f4b9
---------------------------
mem: Use const pointers for port proxy write functions

This patch changes the various write functions in the port proxies
to use const pointers for all sources (similar to how memcpy works).

The one unfortunate aspect is the need for a const_cast in the packet,
to avoid having to juggle a const and a non-const data pointer. This
design decision can always be re-evaluated at a later stage.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Do we need this scope resolution?	Nilay Vaish	Nov. 18, 2014, 11:04 a.m.	Dropped

src/mem/port_proxy.cc (Diff revision 1)

Do we need this scope resolution?

Show all issues

Andreas Hansson Nov. 18, 2014, 8:16 a.m. (Nov. 18, 2014, 8:16 a.m.)

We do. It took me the better part of a day to track it down even...

Ship It!

src/mem/packet.hh (Diff revision 1)

Would it make sense to have an internal 'const' flag that we assert is cleared when calling the non-const getPtr() accessors?  That could even be enabled optionally only for debug builds if desired.

Andreas Hansson Nov. 30, 2014, 1:29 a.m. (Nov. 30, 2014, 1:29 a.m.)

I have a follow up patch that is a bit more kosher regarding the const handling. The challenge is that a lot of the devices have a single function that read/write packets with a boolean parameter for is_read. Thus, they all need non-const pointers and thus taint the packet. Until that is split or reorganised I do not think there is much point.

Good idea though :-)

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)