src/mem/packet.hh (Diff revision 1)

I suggest we change the name of this and other such functions from assert* to set*.  If someone were to tell me just the name of the function, I would assume the function tests the mem inhibit property for being true, like the C assert() function does.  I am guessing the name has been taken from usage we come across in texts on digital logic design.

Show all issues

1. Andreas Hansson Nov. 25, 2014, 2:05 p.m. (Nov. 25, 2014, 2:05 p.m.)

   I have no objection to either, but it is definitely not something for this patch.
   
   I suggest to bring that discussion to the dev list. Set or Assert are both fine with me.

2. Steve Reinhardt Nov. 29, 2014, 1 p.m. (Nov. 29, 2014, 1 p.m.)

   Yes, it's definitely using the EE definition of "assert" rather than the CS definition of "assert".  The ideal gem5 developer is fluent in both dialects :).  I see your point, but I'm not convinced it's worth changing.

Ship It!