mem: Cleanup Packet::checkFunctional and hasData usage

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10548:2b33b6c6b656
---------------------------
mem: Cleanup Packet::checkFunctional and hasData usage

This patch cleans up the use of hasData and checkFunctional in the
packet. The latter function is also tidied up to avoid name overloading.

Testing Done

Issue Summary

Description	From	Last Updated	Status
It's used to check against MSHRs. I honestly do not know the historical reasons for this (which is also why ...	Andreas Hansson	Nov. 29, 2014, 2:23 a.m.	Dropped

src/mem/packet.hh (Diff revision 1)

Object of type Printable? Should this not be something else?

src/mem/packet.hh (Diff revision 1)

It's used to check against MSHRs. I honestly do not know the historical reasons for this (which is also why I haven't changed it...)

Show all issues

Steve Reinhardt Nov. 29, 2014, 1:29 p.m. (Nov. 29, 2014, 1:29 p.m.)

It's an ancient and rarely used facility I added a long time ago (Jan 2008, according to the log, see http://repo.gem5.org/gem5/rev/e902f12a3af1 and http://repo.gem5.org/gem5/rev/30997e988446).

Basically it builds on the functional access framework that traverses the whole memory system looking for copies of a cache block, but instead of reading/updating those copies, it prints information about those copies (where they live, what their state is, etc.).  I found an email I sent doumenting this feature to the m5-dev list, apparently shortly before we started archiving it, so I can't even send you a link :).  I'll put it up on the wiki later; if no one finds it useful, we could get rid of it.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)