scons: Ensure dictionary iteration is sorted by key

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10585:b1d0bbd16e54
---------------------------
scons: Ensure dictionary iteration is sorted by key

This patch adds sorting based on the SimObject name or parameter name
for all situations where we iterate over dictionaries. This should
ensure a deterministic and consistent order across the host systems
and hopefully avoid regression results differing across python
versions.

Testing Done

Andreas Hansson Nov. 30, 2014, 1:13 a.m. (Nov. 30, 2014, 1:13 a.m.)

Your right on both points. I'll break it out in a separate patch, and indeed there is a typo in the link. Well spotted.

SConstruct (Diff revision 1)

Does this belong in a separate patch?

SConstruct (Diff revision 1)

Is this the right link?  The bug there doesn't look related.  I think you mean 2811.

Description:

~		Changeset 10585:54ddda0dc920
	~	Changeset 10585:b1d0bbd16e54

		scons: Ensure dictionary iteration is sorted by key

		This patch adds sorting based on the SimObject name or parameter name
		for all situations where we iterate over dictionaries. This should
		ensure a deterministic and consistent order across the host systems
		and hopefully avoid regression results differing across python
		versions.

Diff:

Revision 2 (+9 -9)

Show changes

	SConstruct
	src/SConscript
	src/python/m5/SimObject.py

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 10585:54ddda0dc920

Changeset 10585:b1d0bbd16e54

Diff:

Status: Closed (submitted)