arm: Merge ISA files with pseudo instructions
Review Request #2567 - Created Dec. 12, 2014 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10612:2bd582d94965 --------------------------- arm: Merge ISA files with pseudo instructions This changeset moves the pseudo instructions used to signal unknown instructions and unimplemented instructions to the same source files as the decoder fault.
Posted (Dec. 12, 2014, 2:24 p.m.)
While it's definitely nice to get these into regular C++ instead of the ISA language, my concern is that these aren't really pseudo instructions. They are in the sense that they're instructions that wouldn't exist outside of the simulator, but there's a well defined pseudo inst concept they don't really fit in. Maybe put them in a .cc and .hh file with a different name?
As I mentioned in the email thread, we're not very consistent in distinguishing "pseudoinstructions" from "m5ops" from whatever other related but distinct categories we have. It would be nice to clean that up, but I don't think this patch makes things any worse, so I don't object.