ruby: move g_abs_controls from global into RubySystem
Review Request #2903 - Created June 18, 2015 and submitted
| Information | |
|---|---|
| Brandon Potter | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 10878:9b1f89a1a3a8 --------------------------- ruby: move g_abs_controls from global into RubySystem
Posted (June 19, 2015, 7:30 a.m.)
Drop g_ from the variable g_abs_controls.
Awesome. Always good to see a global variable go away.
To add on to Nilay, I'd suggest a better name while we're at it. What is "abs"? abstract? absolute? I'd go with "all_controllers", but I'm ok with how it is too.
Posted (June 19, 2015, 8:31 a.m.)
Can you please expand on the commit message? I understand that these changes are to allow multiple RubySystem instances, but some detailed information about this should be available in the commit log.
Review request changed
Updated (June 22, 2015, 6:03 p.m.)
Ship It!
Review request changed
Updated (June 26, 2015, 10:40 a.m.)
Diff: |
Revision 3 (+19 -107)
|
|---|