Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10928:dc89ce497741
---------------------------
misc: add a vimrc that mathces gem5 style guide

Testing Done

Ship It!

What about adding the following?
set spell

set listchars=tab:›\ ,trail:•,extends:#,nbsp:.

Brandon Potter July 24, 2015, 9:50 a.m. (July 24, 2015, 9:50 a.m.)

Sorry, I meant to comment out the set listchars line by default - not highlight it in Reviewboard.

Both are preferences, but help to highlight potential style problems. (For instance, someone else might put tabs or extras spaces in a file which isn't typically noticed.) The spelling check is really helpful, but some might find it distracting.

Tony Gutierrez July 24, 2015, 10:14 a.m. (July 24, 2015, 10:14 a.m.)
```
Sure, I've added them.
```

Description:

~		Changeset 10928:e712d7d61644
	~	Changeset 10928:2887789ee53c

		misc: add a vimrc that mathces gem5 style guide

Diff:

Revision 2 (+74)

Show changes

util/vi/vimrc

Description:

~		Changeset 10928:2887789ee53c
	~	Changeset 10928:1b60547a7fa4

		misc: add a vimrc that mathces gem5 style guide

Diff:

Revision 3 (+89)

Show changes

util/vi/vimrc

Description:

~		Changeset 10928:1b60547a7fa4
	~	Changeset 10928:dc89ce497741

		misc: add a vimrc that mathces gem5 style guide

Diff:

Revision 4 (+91)

Show changes

util/vi/vimrc

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

misc: add a vimrc that mathces gem5 style guide

Screenshots

Files

set listchars=tab:›\ ,trail:•,extends:#,nbsp:.

Description:

Changeset 10928:e712d7d61644

Changeset 10928:2887789ee53c

Diff:

Description:

Changeset 10928:2887789ee53c

Changeset 10928:1b60547a7fa4

Diff:

Description:

Changeset 10928:1b60547a7fa4

Changeset 10928:dc89ce497741

Diff:

Status: Closed (submitted)