ruby: print addresses in hex

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11118:7bc7e7fee719
---------------------------
ruby: print addresses in hex
Changeset 4872dbdea907 replaced Address by Addr, but did not make changes
to print statements.  So the addresses which were being printed in hex earlier
along with their line address, were now being printed in decimals.  This patch
adds a function printAddress(Addr) that can be used to print the address in hex
along with the lines address.  This function has been put to use in some of the
places.  At other places, change has been made to print just the address in hex.

Testing Done

Issue Summary

Description	From	Last Updated	Status
std::string& ?	Tony Gutierrez	Sept. 18, 2015, 11:14 a.m.	Dropped

src/mem/ruby/common/Address.hh (Diff revision 1)

std::string& ?

Show all issues

Nilay Vaish Sept. 18, 2015, 10:23 a.m. (Sept. 18, 2015, 10:23 a.m.)

From http://en.cppreference.com/w/cpp/io/basic_stringstream/str:
Notes

The copy of the underlying string returned by str is a temporary object that will be destructed at the end of the expression, so directly calling c_str() on the result of str() (for example in auto *ptr = out.str().c_str();) results in a dangling pointer.


Given this, I don't think returning reference would be right.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)