mem: Explicitly check MSHR snoops for cases not dealt with
Review Request #3253 - Created Dec. 9, 2015 and submitted
Changeset 11280:928ce92a062c --------------------------- mem: Explicitly check MSHR snoops for cases not dealt with Add a sanity check to make it explicit that we currently do not allow an I/O coherent agent to directly issue writes into the coherent part of the memory system (it has to go via a cache, and get transformed into a read ex, upgrade or invalidation).
Posted (Dec. 23, 2015, 2:07 p.m.)
src/mem/cache/mshr.cc (Diff revision 1)
The test here is stronger than the comment implies. Going by the comment, I expected the test to be
pkt->needsExclusive() && !pkt->isInvalidate()
which differs from the existing test in that pkt->isInvalidate() does not require pkt->needsExclusive().
Not sure what is intended, but I think either the comment or the test should be updated so the two are consistent.
Review request changed
Updated (Dec. 24, 2015, 12:26 a.m.)
Revision 2 (+9)