mem: Only forward the non-writable flag if truly needed
Review Request #3256 - Created Dec. 9, 2015 and discarded
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11282:bf2ca8cda251 --------------------------- mem: Only forward the non-writable flag if truly needed This patch ensures a cache does not forward the non-writable flag from a CPU-side request unless it has to. Thus, we avoid being overly conservative and returning non-writable responses even when we know that the response is the only writable copy in the system (the request was sent out with NeedsWritable set).
Review request changed
Updated (Dec. 22, 2015, 8:28 a.m.)
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1 -1) |
Posted (Dec. 23, 2015, 6:35 p.m.)
I'm confused... if the request says it needs a writable copy, it will always get a writable copy (invalidating other copies as necessary), so I don't see how we'd end up with a packet that has the until-recently-known-as-shared flag set.