scons: Enable -Wextra by default
Review Request #3261 - Created Dec. 28, 2015 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11290:d416c44fe086 --------------------------- scons: Enable -Wextra by default Make best use of the compiler, and enable -Wextra as well as -Wall. There are a few issues that had to be resolved, but they are all trivial.
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+77 -80) |
Please hold off on committing this while we determine how significant the impact is on our outstanding patches (particularly the GPU model). We definitely support this in the long term, but might need a little more lead time before we're ready for it to be committed.
If you're concerned about maintaining this patch, one approach would be to commit all the code fixes now but hold off on the SConstruct/SConscript changes.
Hey Andreas, this is a really good patch that should lead to code quality improvements. Thanks for posting it! It causes only a handful of syntax warnings in our code, so I think, from our perspective, you can go ahead and commit this.