Review Board 2.0.15


o3: don't pass unnecessary data pointer to read()

Review Request #3268 - Created Dec. 31, 2015 and submitted

Information
Steve Reinhardt
gem5
default
Reviewers
Default
Changeset 11286:527ba63c15a9
---------------------------
o3: don't pass unnecessary data pointer to read()

The read() function merely initiates a memory read operation; the
data doesn't arrive until the access completes and a response packet
is received from the memory system.  Thus there's no need to provide
a data pointer; it's existence is historical.

Getting this pointer out of this internal o3 interface sets the
stage for similar cleanup in the ExecContext interface.  Also
found that we were pointlessly setting the contents at this pointer
on a store forward (the useful memcpy happens just a few lines
below the deleted one).

   
Review request changed
Updated (Jan. 17, 2016, 7:07 p.m.)

Status: Closed (submitted)