o3: don't pass unnecessary data pointer to read()
Review Request #3268 - Created Dec. 31, 2015 and submitted
Changeset 11286:527ba63c15a9 --------------------------- o3: don't pass unnecessary data pointer to read() The read() function merely initiates a memory read operation; the data doesn't arrive until the access completes and a response packet is received from the memory system. Thus there's no need to provide a data pointer; it's existence is historical. Getting this pointer out of this internal o3 interface sets the stage for similar cleanup in the ExecContext interface. Also found that we were pointlessly setting the contents at this pointer on a store forward (the useful memcpy happens just a few lines below the deleted one).
Posted (Dec. 31, 2015, 4:29 a.m.)
Looks good to me. In patch description: its* existence
Posted (Dec. 31, 2015, 6:21 a.m.)
Technically o3 is not a keyword. I'd suggest to make it "cpu" and then get the "o3" part into the description.