style: eliminate explicit boolean comparisons

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11321:42f3fc1ea44c
---------------------------
style: eliminate explicit boolean comparisons

Result of running 'hg m5style --skip-all --fix-control -a' to get
rid of '== true' comparisons, plus trivial manual edits to get
rid of '== false'/'== False' comparisons.

Left a couple of explicit comparisons in where they didn't seem
unreasonable:
invalid boolean comparison in src/arch/mips/interrupts.cc:155
>>        DPRINTF(Interrupt, "Interrupts OnCpuTimerINterrupt(tc) == true\n");<<
invalid boolean comparison in src/unittest/unittest.hh:110
>>            "EXPECT_FALSE(" #expr ")", (expr) == false)<<

Testing Done

Ship It!

I just noticed that we have the occasional foo == NULL / foo != NULL check in the code base. I usually consider this to be on par with foo == False, should we check for that as well?

Steve Reinhardt Feb. 2, 2016, 12:28 p.m. (Feb. 2, 2016, 12:28 p.m.)

This doesn't bother me nearly as much.  It's unnecessary, but it makes an implicit pointer-to-bool conversion explicit, which some might argue is good for readability.  In contrast, the boolean comparisons eliminated in this patch are truly redundant in every sense of the word.  I could go either way though; I wouldn't miss the comparisons with NULL if we did eliminate them.

It would be nice to hear from others on this.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)