mem: Simplify cache packet handling for uncacheable writes
Review Request #3407 - Created March 31, 2016 and submitted
Changeset 11442:338a5d23f371 --------------------------- mem: Simplify cache packet handling for uncacheable writes Cosmetic change following up on the recent cache queue modifications. This patch aligns the handling of uncacheable writes in that no new packets are created, similar to how write evictions are dealt with. By not allocating copies of the packet the code is simplified, and we avoid unecessary memory management.
Review request changed
Updated (April 9, 2016, 9:20 a.m.)
Revision 2 (+14 -44)
Posted (April 17, 2016, 10:06 p.m.)
Hard not to like a change that's a net reduction in LOC!
src/mem/cache/write_queue_entry.hh (Diff revision 2)
Is this 'pkt' field still used? I'd think not, in which case it should of course be deleted. If it is still used, I'd be curious how, since I'm leery of both forwarding the packet down to the next level and keeping a copy of the pointer ourselves---makes the ownership situation ambiguous.