ruby: remove unnecessary C-style explicit boolean cast

Information
Submitter:	Brandon Potter
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11416:607ddbd360ce
---------------------------
ruby: remove unnecessary C-style explicit boolean cast

Testing Done

Would you be against doing if (count > 0)? I think that is more clear than a static cast.

Brandon Potter April 6, 2016, 9:36 a.m. (April 6, 2016, 9:36 a.m.)

The two m_map objects are an unordered_map and an ordered_map. The count method can only return 0 or 1 because duplicates are not allowed in the maps.
So, I think that I will drop the explicit cast and let it happen implicitly. (Not sure what the motivation was for doing the C-style explicit cast.)

Summary:

-	ruby: change !! into static_cast<bool> calls
+	ruby: remove unnecessary C-style explicit boolean cast

Description:

~		Changeset 11416:ce9c6632223b
	~	Changeset 11416:607ddbd360ce

~		ruby: change !! into static_cast<bool> calls
	~	ruby: remove unnecessary C-style explicit boolean cast

Diff:

Revision 2 (+2 -2)

Show changes

	src/mem/ruby/structures/TBETable.hh
	src/mem/ruby/structures/TimerTable.hh

Ship It!

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Summary:

Description:

Changeset 11416:ce9c6632223b

Changeset 11416:607ddbd360ce

Diff: