ruby: add parameters to functions related to addresses
Review Request #3424 - Created April 4, 2016 and updated
Information | |
---|---|
Brandon Potter | |
gem5 | |
default | |
Reviewers | |
Default | |
Changeset 11426:065361f6fd53 --------------------------- ruby: add parameters to functions related to addresses The four functions related to addresses that require knowing the block size are printAddress, getOffset, makeNextStrideAddress, and makeLineAddress. The block size is added to the function signature and is passed into the constructors in this patch.
Issue Summary
1
1
0
0
Description | From | Last Updated | Status |
---|---|---|---|
I think the solution to cleaning up these patches is to make these functions members of RubySystem (instance functions). There's ... | Jason Lowe-Power | April 11, 2016, 2:02 p.m. | Open |
Posted (April 11, 2016, 2:02 p.m.)
-
src/mem/ruby/common/Address.cc (Diff revision 1) -
I think the solution to cleaning up these patches is to make these functions members of RubySystem (instance functions). There's no reason these functions should be static like this.
Then, you only have to modify the places where these functions are called to use the ruby_system pointer that's already in most functions.
Maybe I'm wrong, and maybe it's actually worse this way. What do you think?