Review Board 2.0.15


base: stats: add function for printing text to output

Review Request #3432 - Created April 4, 2016 and updated

Information
Brandon Potter
gem5
default
Reviewers
Default 
Changeset 11434:859f55d0928e
---------------------------
base: stats: add function for printing text to output

This patch overloads the function visit() associated with Output class so that
one can output a string.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Andreas Hansson

   
Posted  (April 6, 2016, 2:39 p.m.)


  


  


  

   
Could you explain why?


In general, for all of these patches, could you please add a brief description of the "why"?



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    The diatribe that I just posted on http://reviews.gem5.org/r/3428/ should give enough insight into why we need to modify the stats framework. Again, somebody decided to use statics to aggregate statistics acrosss a controller type and the result is that it doesn't work for multiple systems.
    

    Nilay wrote this code which allows the controller statistics to be aggregated per system at the end of a simulation.
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    I appreciate the "per system" aspect, but what does that have to do with printing text output? I am somehow not seeing the connection.
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    This patch is a preliminary patch that allows the use of the "visit" method here: http://reviews.gem5.org/r/3431/diff/1/#index_header. It might have been better to have merged the two patches before posting, but I left the patches as they were when I received them from Nilay.
    

    Would you like to see the patches merged so that the purpose of visit() here is clear within the context of what I'm trying to do with the "per system" code?
    
    
    
   
    4. 


   
  4. 
    
    
     
    
      
     
    
     
    Please do. Right now this change seems very random.
    
    
    
   
    5.