ruby: allows multiple instances of ruby to be invoked
Review Request #3442 - Created April 4, 2016 and updated
| Information | |
|---|---|
| Brandon Potter | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11445:699184404794 --------------------------- ruby: allows multiple instances of ruby to be invoked This patch removes the restriction that there can only be a single ruby system object in a given simulation. With the configuration supplied, it is possible to run an instance of ruby with any of the supplied topologies.
Cool! This is much slimmer than prior review requests, and a lot easier to digest. It will be nice to tighten this up more in further requests, but I'm good with this change.
Just minor requests below.
-
src/mem/ruby/network/MessageBuffer.hh (Diff revision 1) -
Not a big deal, but in general, these sorts of changes should be in a separate patch.
-
src/mem/ruby/system/RubyPort.cc (Diff revision 1) -
I think this is actually a bug, and fixing it would clean things up: A RubyPort's ports should be clocked at the same frequency as the RubyPort itself, rather than the RubySystem frequency. Can we just change these to rp->clockPeriod() throughout this file and eliminate the RubySystem indirection in these functions?
-
src/mem/ruby/system/RubyPort.cc (Diff revision 1) -
Same as previous
-
src/mem/ruby/system/RubyPort.cc (Diff revision 1) -
Same as previous.
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+766 -39) |