Review Board 2.0.15


mem: Use FromCache attribute in snoop filter allocation

Review Request #3562 - Created July 12, 2016 and submitted

Information
Andreas Sandberg
gem5
default
Reviewers
Default
Changeset 11564:76718cb08673
---------------------------
mem: Use FromCache attribute in snoop filter allocation

This patch improves the snoop filter allocation decisions by not only
looking at whether a port is snooping or not, but also if the packet
actually came from a cache. The issue with only looking at isSnooping
is that the CPU ports, for example, are snooping, but not actually
caching. Previously we ended up incorrectly allocating entries in
systems without caches (such as the atomic and timing quick
regressions). Eventually these misguided allocations caused the snoop
filter to panic due to an excessive size.

On the request path we now include the fromCache check on the packet
itself, and for responses we check if we actually have a snoop-filter
entry.

Change-Id: Idd2dbc4f00c7e07d331e9a02658aee30d0350d7e
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Stephan Diestelhorst <stephan.diestelhorst@arm.com>

   
Review request changed
Updated (Aug. 12, 2016, 6:07 a.m.)

Status: Closed (submitted)