arch: [Patch 1/5] Added RISC-V base instruction set RV64I

Information
Submitter:	Alec Roelke
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11688:ccda87b39fe5
---------------------------
arch: [Patch 1/5] Added RISC-V base instruction set RV64I

First of five patches adding RISC-V to GEM5. This patch introduces the
base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
The multiply, floating point, and atomic memory instructions will be added
in additional patches, as well as support for more detailed CPU models.
The loader is also modified to be able to parse RISC-V ELF files, and a
"Hello world\!" example for RISC-V is added to test-progs.

Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
the floating point (single- and double-precision) extensions, RV64FD;
patch 4 will implement the atomic memory instructions, RV64A, and patch 5
will add support for timing, minor, and detailed CPU models that is missing
from the first four patches (such as handling locked memory).

[Removed several unused parameters and imports from RiscvInterrupts.py,
RiscvISA.py, and RiscvSystem.py.]
[Fixed copyright information in RISC-V files copied from elsewhere that had
ARM licenses attached.]
[Reorganized instruction definitions in decoder.isa so that they are sorted
by opcode in preparation for the addition of ISA extensions M, A, F, D.]
[Fixed formatting of several files, removed some variables and
instructions that were missed when moving them to other patches, fixed
RISC-V Foundation copyright attribution, and fixed history of files
copied from other architectures using hg copy.]
[Fixed indentation of switch cases in isa.cc.]
[Reorganized syscall descriptions in linux/process.cc to remove large
number of repeated unimplemented system calls and added implmementations
to functions that have received them since it process.cc was first
created.]
[Fixed spacing for some copyright attributions.]
[Replaced the rest of the file copies using hg copy.]
[Fixed style check errors and corrected unaligned memory accesses.]
[Fix some minor formatting mistakes.]
Signed-off by: Alec Roelke

Testing Done

Issue Summary

Description	From	Last Updated	Status
I didn't see num_threads or num_vpes ever used. If these aren't used they should be removed. Also, is `system` ever ...	Jason Lowe-Power	Sept. 15, 2016, 1:26 p.m.	Resolved
For all of these parameters: are they used by the RiscvSystem code? Will they be used in the future? It ...	Jason Lowe-Power	Sept. 15, 2016, 1:26 p.m.	Resolved
Does this mean RISC-V only supports 32 bit? (I noticed the x86 mask is 64-bit.)	Jason Lowe-Power	Sept. 15, 2016, 1:26 p.m.	Resolved
Is this paraemter ever used? I didn't see it.	Jason Lowe-Power	Sept. 15, 2016, 1:28 p.m.	Resolved
Regarding the license edits, the "normal" 3-clause BSD is the bottom two paragraphs. I would encourage you to add your ...	Andreas Hansson	Sept. 19, 2016, 11:46 a.m.	Resolved
Would be good to stick to the same spacing, and not change the AARCH64 line	Andreas Hansson	Oct. 13, 2016, 9:47 a.m.	Resolved
Could you perhaps elaborate on why this is ok as is?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
odd indentation here	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
odd indentation	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
Not that it matters, but could you update this as well?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
? Is that a legal entity?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
Same as above	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
RISCV has mmapped IPRs?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
What are the implications? Also, should this class not inherint from Serializable?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
ARCH_RISCV_...	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
This block has some formatting issues. Space around operators, and I think it is officially a convention to also keep ...	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
I am really surprise that this and a few other files do not have a Uni Virginia copyright. Is that ...	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
Not convention	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Dropped
I think this particular line should not be changed and the line below should stick with the same spacing.	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
Was the spacing like this already?	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
Was the spacing like this (in this and other files)? I think traditionally we did not align the legal entity ...	Andreas Hansson	Oct. 13, 2016, 9:46 a.m.	Resolved
Is this based on a spec? If so, could you provide a pointer?	Andreas Hansson	Oct. 13, 2016, 9:45 a.m.	Dropped
Not that it really matters, but feel free to use "auto"	Andreas Hansson	Oct. 13, 2016, 9:45 a.m.	Resolved
Spacing as before	Andreas Hansson	Oct. 13, 2016, 9:45 a.m.	Resolved
misspelled 'Berkeley' :)	Steve Reinhardt	Oct. 21, 2016, 11:12 a.m.	Resolved
space after 'if' (here and below)... even though these aren't C++ files, the C++ code should still follow the style ...	Steve Reinhardt	Oct. 21, 2016, 11:12 a.m.	Resolved
shouldn't this be 'false'? or is the comment incorrect?	Steve Reinhardt	Oct. 21, 2016, 11:12 a.m.	Resolved
Do you really need a microcode ROM? Seems like this whole file should not be necessary.	Steve Reinhardt	Oct. 31, 2016, 6:38 p.m.	Dropped
nullptr. Fix throughout.	Tony Gutierrez	Oct. 31, 2016, 6:29 p.m.	Resolved
Are these duplicate values right?	Tony Gutierrez	Oct. 31, 2016, 6:38 p.m.	Dropped
Public/private should be indented 2 spaces. Fix throughout.	Tony Gutierrez	Oct. 31, 2016, 6:29 p.m.	Resolved

Thanks for the contribution. It looks pretty good! Could you give us a preview as to the other 4 patches? What is missing in this one?

I know nothing of how the ISA stuff works in gem5, but I reviewed most of the other parts of this patch.

Some high-level notes:

a.out probably shouldn't be in the patch.

Make sure you've updated all of the copyright information.

Have you run any of the RISC-V test suite on your code? (https://riscv.org/software-tools/riscv-tests/) In fact, we could probably incorporate some (all?) of that into the regression tests. How much we include depends on how long the tests take.

Alec Roelke Sept. 15, 2016, 11:18 a.m. (Sept. 15, 2016, 11:18 a.m.)

Yeah, I just noticed a.out. Is there a way to prevent SCons from producing it?

Which copyright information are you referring to? I went through and added it where I thought it was necessary, but I'm not very familiar with copyrights and licensing so I could have gotten it wrong.

I have tried running the some of the RISC-V tests, but they don't seem have the structure that GEM5 expects--for example, the entry point of rv64ui-p-add as defined by the ELF file doesn't exist in the disassembly.

Jason Lowe-Power Sept. 15, 2016, 11:39 a.m. (Sept. 15, 2016, 11:39 a.m.)

I don't know how to get rid of a.out. If you find out, let me know too!
For the copyright. It seemed there were a number of files that you created that had other people's name on them (e.g., src/arch/riscv/RiscvInterrupts.py). Sincd you changed pretty much every line in that file, and created the file, you can add your copyright and author name.
Finally, that's unfortunate about the RISC-V tests. Is there a way to slightly modify the loading of gem5 to support them? Maybe this is something for a separate patch. It would be really great to run tests like this.

Alec Roelke Sept. 15, 2016, 1:19 p.m. (Sept. 15, 2016, 1:19 p.m.)

The files that I didn't put my name in were not created by me; this project originated from earlier work we found on GitHub (basically from searching Google to see if someone had already done it). While there are heavy modifications that I made in general as beforehand very little was implemented, the files that I didn't touch at all, or that I only changed formatting for, I left with the original copyright information. Same for files I copied from MIPS without editing (I think that's only the TLB though).

The RISC-V GNU toolchain comes with an architecture simulator that is basically a dressed-down version of gem5's atomic CPU model and is able to run those tests, so it could be possible to modify gem5's ELF loader to work. On the other hand, if you want to run code compiled with the GNU toolchain on their simulator, you have to also use their proxy kernel, which crashes when you try to give it a RISC-V ISA test to run. I think the simulator probably uses a different entry point than the ELF file defines and the proxy kernel is responsible for reading it to determine the proper entry point, which gem5 does internally. Not to mention that the tests don't actually have any output themselves--whatever hardware or software is performing them is responsible for knowing if they've passed or not.

Jason Lowe-Power Sept. 15, 2016, 1:28 p.m. (Sept. 15, 2016, 1:28 p.m.)

Ah, that makes sense with the copyright. Thanks for clarifying.

Too bad it wasn't easy to use their tests! Thanks for the info, though.

ext/libelf/elf_common.h (Diff revision 1)

It would be nice if this were aligned with the above.

Alec Roelke Sept. 15, 2016, 11:18 a.m. (Sept. 15, 2016, 11:18 a.m.)

Do you mean the two lines immediately preceding it? It is aligned with most of the other EM definitions.

Jason Lowe-Power Sept. 15, 2016, 11:41 a.m. (Sept. 15, 2016, 11:41 a.m.)

It's a silly nit, not very important. But the 243 doesn't appear to be in line with the 183. Same for the comment with the comment on the preceeding line. Maybe it's an accidental tab instead of spaces?

src/arch/riscv/RiscvISA.py (Diff revision 1)

I didn't see num_threads or num_vpes ever used. If these aren't used they should be removed.

Also, is system ever used?

Show all issues

src/arch/riscv/RiscvSystem.py (Diff revision 1)

For all of these parameters: are they used by the RiscvSystem code? Will they be used in the future?

It looks like you copied a lot of this code from MIPS. If the code isn't applicable to RISC-V, it should be removed.

Show all issues

src/arch/riscv/RiscvSystem.py (Diff revision 1)

Does this mean RISC-V only supports 32 bit? (I noticed the x86 mask is 64-bit.)

Show all issues

src/arch/riscv/RiscvSystem.py (Diff revision 1)

Is this paraemter ever used? I didn't see it.

Show all issues

Description:

~		Changeset 11620:80e562ddf946
	~	Changeset 11620:849620cf01a3

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

Diff:

Revision 2 (+8298 -1)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	55 more

Description:

~		Changeset 11620:849620cf01a3
	~	Changeset 11620:01bf9539be09

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.
	+
	+	Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
	+	the floating point (single- and double-precision) extensions, RV64FD;
	+	patch 4 will implement the atomic memory instructions, RV64A, and patch 5
	+	will add support for timing, minor, and detailed CPU models that is missing
	+	from the first four patches (such as handling locked memory).
	+
	+	[Removed several unused parameters and imports from RiscvInterrupts.py,
	+	RiscvISA.py, and RiscvSystem.py.]
	+	Signed-off by: Alec Roelke

Diff:

Revision 3 (+8067 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

src/arch/riscv/RiscvISA.py (Diff revisions 2 - 3)

Regarding the license edits, the "normal" 3-clause BSD is the bottom two paragraphs.

I would encourage you to add your Copyright notice only for those paragraphs, and not the first one in the files with three. The top paragraph in this and other files with three paragraphs is an ARM addition that is technically an extension to the 3-clause BSD. You have a number of examples throughout the codebase.

Makes sense?

Show all issues

Alec Roelke Sept. 16, 2016, 9:38 a.m. (Sept. 16, 2016, 9:38 a.m.)
```
That does make sense.  Thanks for your help.
```

Description:

~		Changeset 11620:01bf9539be09
	~	Changeset 11620:cceb2cc47bdd

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
	+	[Fixed copyright information in RISC-V files copied from elsewhere that had
	+	ARM licenses attached.]
		Signed-off by: Alec Roelke

Diff:

Revision 4 (+8075 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Description:

~		Changeset 11620:cceb2cc47bdd
	~	Changeset 11620:3da42ffa5b4b

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
	+	[Reorganized instruction definitions in decoder.isa so that they are sorted
	+	by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		Signed-off by: Alec Roelke

Diff:

Revision 5 (+8075 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Thanks again for getting this in shape. There are a few minor questions and comment on the patch, the most important one is related to the copyrights.

Also, I assume you have used hg copy for the files that are more or less 1:1 copies from other architectures?

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

I didn't; I used cp and then hg add. Does hg copy do anything different?

Andreas Hansson Sept. 28, 2016, 1:37 p.m. (Sept. 28, 2016, 1:37 p.m.)

Yeah that is a bit of an issue. If you didn't actually use hg copy then all history of the file is lost. Sorry to be a drag, but could you redo it using hg copy?

Alec Roelke Sept. 28, 2016, 7:48 p.m. (Sept. 28, 2016, 7:48 p.m.)

Yes, I will go through and replace copies (or near copies) with hg copy.

Alec Roelke Sept. 29, 2016, 12:04 p.m. (Sept. 29, 2016, 12:04 p.m.)

I ended up only doing this for files that I copied myself (tlb, pagetable, and files in linux). I did not do this with files that could have been copies but were from the original GitHub project, as I don't know how they were created. If you think I should do this for them as well (and thus removing the copyrights from the GitHub project and replacing them with those of the equivalent files in MIPS), I can do it.

ext/libelf/elf_common.h (Diff revision 5)

Would be good to stick to the same spacing, and not change the AARCH64 line

Show all issues

src/arch/riscv/faults.hh (Diff revision 5)

Could you perhaps elaborate on why this is ok as is?

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

Currently this only supports SE mode, which doesn't have elevated privilege (which is also why the eret instruction is not implemented). That is a reminder to me of how I intended for that fault to change when elevated privilege is implemented (or a hint to the person who does it if I don't). Is it not appropriate to include it?

Andreas Hansson Sept. 28, 2016, 1:37 p.m. (Sept. 28, 2016, 1:37 p.m.)

Fair enough. Feel free to leave it. I would imagine if you called out every location there would be tons of TODOs though :-)

src/arch/riscv/faults.cc (Diff revision 5)

odd indentation here

Show all issues

src/arch/riscv/faults.cc (Diff revision 5)

odd indentation

Show all issues

src/arch/riscv/idle_event.hh (Diff revision 5)

Not that it matters, but could you update this as well?

Show all issues

src/arch/riscv/isa/base.isa (Diff revision 5)

? Is that a legal entity?

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

Some of the files in this project were originally from a GitHub project by Austin Harris. In those cases, I left whatever copyright was originally there in addition to adding mine if I felt it was appropriate.

Andreas Hansson Sept. 28, 2016, 1:37 p.m. (Sept. 28, 2016, 1:37 p.m.)

I don't want to cause too much effort on your end, but I really think we need to get this right. Should Austin have used that entity for the copyright? Is it even a real legal entity? Could you reach out to him and check? We really need to get this right imho.

Alec Roelke Sept. 28, 2016, 7:48 p.m. (Sept. 28, 2016, 7:48 p.m.)

I did some looking around the RISC-V website, and I believe the entity is "RISC-V Foundation" according to its copyright. I'll make the change, and add it to other files I think are related to the ISA specification like faults and registers.hh.

src/arch/riscv/isa/bitfields.isa (Diff revision 5)

Same as above

Show all issues

src/arch/riscv/mmapped_ipr.hh (Diff revision 5)

RISCV has mmapped IPRs?

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

This file was from the original GitHub project, and appears to be required by the CPU models.

Andreas Hansson Sept. 28, 2016, 1:37 p.m. (Sept. 28, 2016, 1:37 p.m.)

I see. Someone more familiar with the CPU model could perhaps comment? I find it odd that we need it when only ALPHA has the construct.

Alec Roelke Sept. 28, 2016, 7:48 p.m. (Sept. 28, 2016, 7:48 p.m.)

I'll take a look at other non-Alpha ISAs and see if I can remove it.

src/arch/riscv/pagetable.hh (Diff revision 5)

What are the implications?
Also, should this class not inherint from Serializable?

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

This is copied from MIPS, with some name changes. I had been focused on getting RISC-V running, and haven't gotten to properly implementing the TLB yet.

src/arch/riscv/process.hh (Diff revision 5)

ARCH_RISCV_...

Show all issues

src/arch/riscv/process.cc (Diff revision 5)

This block has some formatting issues. Space around operators, and I think it is officially a convention to also keep the operator on the line of the first operand.

Show all issues

src/arch/riscv/tlb.cc (Diff revision 5)

I am really surprise that this and a few other files do not have a Uni Virginia copyright. Is that intentional?

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)

Files that I copied from other ISAs, and only made minor changes like names, I didn't feel merited that addition, so I left them as they are.

Andreas Hansson Sept. 28, 2016, 1:37 p.m. (Sept. 28, 2016, 1:37 p.m.)

Makes sense. My rule is usually: If it's trivial to make the change using a sed script then don't bother.

As mentioned above, please make sure you use hg copy so that the revision history is maintained.

src/arch/riscv/tlb.cc (Diff revision 5)

Not convention

Show all issues

Alec Roelke Sept. 27, 2016, 6:36 p.m. (Sept. 27, 2016, 6:36 p.m.)
```
See my comment for pagetable.hh.
```

src/arch/riscv/tlb.cc (Diff revision 5)

Show all issues

Description:

~		Changeset 11620:3da42ffa5b4b
	~	Changeset 11655:d0ecf8ecc940

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
	+	[Fixed formatting of several files, removed some variables and
	+	instructions that were missed when moving them to other patches, fixed
	+	RISC-V Foundation copyright attribution, and fixed history of files
	+	copied from other architectures using hg copy.]
		Signed-off by: Alec Roelke

Diff:

Revision 6 (+7996 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Description:

~		Changeset 11655:d0ecf8ecc940
	~	Changeset 11655:d4aaaa876749

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
	+	[Fixed indentation of switch cases in isa.cc.]
	+	[Reorganized syscall descriptions in linux/process.cc to remove large
	+	number of repeated unimplemented system calls and added implmementations
	+	to functions that have received them since it process.cc was first
	+	created.]
		Signed-off by: Alec Roelke

Diff:

Revision 7 (+6002 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Description:

~		Changeset 11655:d4aaaa876749
	~	Changeset 11655:01b1d852e62e

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
		[Fixed indentation of switch cases in isa.cc.]
		[Reorganized syscall descriptions in linux/process.cc to remove large
		number of repeated unimplemented system calls and added implmementations
		to functions that have received them since it process.cc was first
		created.]
		Signed-off by: Alec Roelke

Diff:

Revision 8 (+6002 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

ext/libelf/elf_common.h (Diff revision 8)

I think this particular line should not be changed and the line below should stick with the same spacing.

Show all issues

Alec Roelke Oct. 12, 2016, 9:25 a.m. (Oct. 12, 2016, 9:25 a.m.)

That line is as it was before my patch. The other EM_X definitions all use a tab+spaces for alignment while EM_AARCH64 only uses spaces. I decided to align EM_RISCV with the others using a tab+spaces and leave EM_AARCH64 alone. Personally I think it should be changed so they all use only spaces, but I don't think this patch is the right place to do it.

src/arch/riscv/isa_traits.hh (Diff revision 8)

Was the spacing like this already?

Show all issues

src/arch/riscv/microcode_rom.hh (Diff revision 8)

Was the spacing like this (in this and other files)? I think traditionally we did not align the legal entity names.

Show all issues

Alec Roelke Oct. 12, 2016, 9:25 a.m. (Oct. 12, 2016, 9:25 a.m.)
```
It was (same for the others).  I'll change it though.
```

src/arch/riscv/process.cc (Diff revision 8)

Is this based on a spec? If so, could you provide a pointer?

Show all issues

Alec Roelke Oct. 12, 2016, 9:25 a.m. (Oct. 12, 2016, 9:25 a.m.)

I do remember referring to something when I was writing this, but it wasn't either of the volumes of the RISC-V specification and I can't find it anymore. I believe it was a source file somewhere in the riscv toolchain which had a comment describing the organization of program arguments upon entry. As for the values in the constructor of RiscvLiveProcess like stack_base, it didn't specify. I ended up using the ones from MIPS, except that the break point isn't rounded because that causes gem5 to crash when trying to run a program.

src/arch/riscv/process.cc (Diff revision 8)

Not that it really matters, but feel free to use "auto"

Show all issues

Alec Roelke Oct. 12, 2016, 9:25 a.m. (Oct. 12, 2016, 9:25 a.m.)

Actually I think I'll just use "int" as most people do. I'm not sure what I was thinking when I did this.

src/arch/riscv/registers.hh (Diff revision 8)

Spacing as before

Show all issues

Some minor questions and cosmetic issues.

Could you please also confirm that the files that are copied (and then modified) started out as hg copy (as previously discussed).

Besides that I think this is looking really good. Thanks Alec!

Steve, can we retire Alpha now to make up for the additional build and test time? :-)

Alec Roelke Oct. 12, 2016, 9:25 a.m. (Oct. 12, 2016, 9:25 a.m.)

I went through and made sure to use hg copy on files that I copied. Ones that were similar but were from the original GitHub I didn't do this with, such as mmapped_ipr.hh (which I've learned is present in the other ISAs). Is there a way to check to make sure I did it right?

Also, as a heads up, I'm adding a sixth patch in the next few days that will have a (more) proper implementation of the files in the linux/ directory. Currently the system calls technically work, but the structure of the data structures for calls like stat aren't what RISC-V programs are expecting. So far I've only run into this for stat and fstat.

Andreas Hansson Oct. 13, 2016, 6:24 a.m. (Oct. 13, 2016, 6:24 a.m.)

All sounds good. I'm not aware of any good way to check besides manually inspecting the patch. If you have someone else's copyright and it says "new" then clearly something is not right.

Could you close (fixed or drop) the issues that are open?

Alec Roelke Oct. 13, 2016, 9:46 a.m. (Oct. 13, 2016, 9:46 a.m.)

I went through and did hg copy on all the files that could have been copies (basically that didn't have my copyright on them). There are a couple of problem files, though: vtophys.hh, types.hh, remote_gdb.cc, and remote_gdb.hh. I did not create them, but they aren't copies of any of the other architectures since they're basically stubs (although in the RV64A patch I do modify types.hh and have my copyright added). Should I leave them as is?

Andreas Hansson Oct. 13, 2016, 9:58 a.m. (Oct. 13, 2016, 9:58 a.m.)

No objections from my end.

Thanks again for all the effort in getting this right.

Description:

~		Changeset 11655:01b1d852e62e
	~	Changeset 11655:e462a5c2cca2

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
		[Fixed indentation of switch cases in isa.cc.]
		[Reorganized syscall descriptions in linux/process.cc to remove large
		number of repeated unimplemented system calls and added implmementations
		to functions that have received them since it process.cc was first
		created.]
	+	[Fixed spacing for some copyright attributions.]
		Signed-off by: Alec Roelke

Diff:

Revision 9 (+6002 -2)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Description:

~		Changeset 11655:e462a5c2cca2
	~	Changeset 11655:fce68047f694

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
		[Fixed indentation of switch cases in isa.cc.]
		[Reorganized syscall descriptions in linux/process.cc to remove large
		number of repeated unimplemented system calls and added implmementations
		to functions that have received them since it process.cc was first
		created.]
		[Fixed spacing for some copyright attributions.]
	+	[Replaced the rest of the file copies using hg copy.]
		Signed-off by: Alec Roelke

Diff:

Revision 10 (+5967 -1)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	53 more

Looks good to me. It would be good if someone else could review this as well.

Sorry for the slow reviewing. I have a few minor changes.

First, when I apply the patch, I get a number of errors from the style checker. Make sure you're using the most up-to-date version of gem5 when you rebase your patch.

Second, when I apply the patch and try to compile, I get a number of errors. Most are about the endianness functions:
build/RISCV/config/the_isa.hh:25:16: error: 'gtoh' is not a member of 'RiscvISA'

Third, I'm getting a number of "unused-variable" warnings (errors). If the variables are used for debugging (e.g., in asserts) you can use the macro M5_VAR_USED after the variable name and before the assignment.

I'm not sure if the problem is that you've based this on an older version of gem5, or maybe we're just using different compilers (I'm use gcc-4.8).

Alec Roelke Oct. 20, 2016, 2:25 p.m. (Oct. 20, 2016, 2:25 p.m.)

I ignored a few of the style warnings because I saw some other places in gem5's code where the character limit was ignored. I'll go back through and try to fix them all though. I think for remote_gdb there are some (a lot of) warnings about "invalid control characters" that I wasn't sure how to fix.

I built this using a system running Ubuntu 16.04, which has gcc 5.3 and doesn't have any errors or warnings like you're describing. I tried compiling it on a virtual machine running Ubuntu 14.04 and gcc 4.8.4, it also works. I tested with gem5.debug and gem5.fast.

Jason Lowe-Power Oct. 21, 2016, 7:41 a.m. (Oct. 21, 2016, 7:41 a.m.)

Thanks for fixing the style errors. Although there are still some places that don't follow the style guide in the code, we try to fix all of these as we find them. Definitely any new code should follow all of the style guidelines.

I'm not sure why I was having errors yesterday. They've magically resolved themselves overnight. Hopefully you didn't spend too much time looking into it :).

Alec Roelke Oct. 21, 2016, 8:45 a.m. (Oct. 21, 2016, 8:45 a.m.)

Okay, I'll fix the rest of them, then (and in other patches too).

I actually figured it out. In my original code, there was a weird bug in isa/includes.isa where sim/system.hh had to be included out of order in, I believe, the decoder or the errors you mentioned would pop up. I added an include for it into registers.hh and it fixed it.

Jason Lowe-Power Oct. 21, 2016, 1:42 p.m. (Oct. 21, 2016, 1:42 p.m.)

I see, I bet it was that I fixed some of the include orderings and got that error.
I have another question, though...
I'm trying to test this out myself. I downloaded the compiler from https://github.com/riscv/riscv-gnu-toolchain and then build hello with riscv64-unknown-linux-gnu-gcc ../../../src/hello.c -o hello -static -march=RV64I.
When trying to run the binary I'm getting the error
panic: Unknown instruction 0x03755433 at pc 0x000000000002e1b8
 @ tick 318000


What am I doing wrong? I'm using configs/learning_gem5/part1/simple.py with changes to use the atomic CPU instead of the timing.
Thanks for all your work!

Alec Roelke Oct. 21, 2016, 2:18 p.m. (Oct. 21, 2016, 2:18 p.m.)

I have been using riscv64-unknown-elf-gcc rather than riscv64-unknown-gnu-linux-gcc.  I don't know if riscv-gnu-toolchain will build riscv64-unknown-elf-gcc, but you can get riscv-tools and build that, and then you get riscv64-unknown-elf-gcc (and spike if you're interested in playing around with that).  I tried using riscv64-unknown-gnu-linux-gcc, but I encountered a problem where gem5 would return from a function and then read 0x00000000 as an instruction even though the instruction at the corresponding PC in the assembly is valid.
This doesn't appear to be your problem, though.  Your instruction appears to be a multiply instruction, which isn't part of RV64I.  I'm not sure why the compiler would do that when you specified -march=RV64I unless that's just a suggestion and doesn't bind it to anything.  However, I do recall that riscv64-unknown-elf-gcc should not use a multiply when invoking printf with only a single argument that's a string literal.
I think your options are to either apply patch 2, which adds integer multiply instructions, or try using riscv64-uknown-elf-gcc instead of riscv64-unknown-gnu-linux-gcc.  I would recommend the former, since trying the latter might cause a different problem that I mentioned earlier.  If all you want to do is run something, there should also be a precompiled hello binary in tests/test-progs/hello/bin/riscv/linux/.

Alec Roelke Oct. 21, 2016, 2:22 p.m. (Oct. 21, 2016, 2:22 p.m.)

I forgot to mention, I've just been using straight configs/example/se.py to run my code. I don't think that should make a difference, though.

Jason Lowe-Power Oct. 21, 2016, 3:29 p.m. (Oct. 21, 2016, 3:29 p.m.)

Ok. I'll play around with it soon.

The binary isn't in the diff, unfortunately. That's why I was compiling it on my own. If I still have issues I may ask you to send me the binary off-list.

Alec Roelke Oct. 21, 2016, 5:47 p.m. (Oct. 21, 2016, 5:47 p.m.)
```
Oh, I thought I had added it.  Should I not add it?
```

Jason Lowe-Power Oct. 21, 2016, 6:56 p.m. (Oct. 21, 2016, 6:56 p.m.)

You added it. It just doesn't show up on reviewboard. It's a reviewboard issue.

Looks good overall! Just a few minor nits, really.

ext/libelf/elf_common.h (Diff revision 10)

misspelled 'Berkeley' :)

Show all issues

src/arch/riscv/isa/formats/mem.isa (Diff revision 10)

space after 'if' (here and below)... even though these aren't C++ files, the C++ code should still follow the style guide

Show all issues

src/arch/riscv/isa_traits.hh (Diff revision 10)

shouldn't this be 'false'? or is the comment incorrect?

Show all issues

src/arch/riscv/microcode_rom.hh (Diff revision 10)

Do you really need a microcode ROM? Seems like this whole file should not be necessary.

Show all issues

Alec Roelke Oct. 21, 2016, 11:12 a.m. (Oct. 21, 2016, 11:12 a.m.)

I don't think it should be required, but microcode_rom.hh is required by mem/abstract_mem.cc and the type MicrocodeRom is needed by several files in cpu, so it's just copied from another ISA.

Description:

~		Changeset 11655:fce68047f694
	~	Changeset 11688:f84b3613acf4

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
		[Fixed indentation of switch cases in isa.cc.]
		[Reorganized syscall descriptions in linux/process.cc to remove large
		number of repeated unimplemented system calls and added implmementations
		to functions that have received them since it process.cc was first
		created.]
		[Fixed spacing for some copyright attributions.]
		[Replaced the rest of the file copies using hg copy.]
	+	[Fixed style check errors and corrected unaligned memory accesses.]
		Signed-off by: Alec Roelke

Diff:

Revision 11 (+5980 -1)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	52 more

Sorry for the delay. I finally got everything working and it looks good to me! I'll start testing the other patches in the series soon.

A few minor things, otherwise it looks pretty good.

src/arch/riscv/decoder.hh (Diff revision 11)

nullptr. Fix throughout.

Show all issues

src/arch/riscv/faults.hh (Diff revision 11)

Are these duplicate values right?

Show all issues

Alec Roelke Oct. 31, 2016, 6:29 p.m. (Oct. 31, 2016, 6:29 p.m.)

Yes. RISC-V doesn't distinguish between misaligned addresses with store instructions or AMO instructions, but since it does distinguish between those and misaligned load addresses, I felt having separate constants with the same value would be appropriate. The values can be found on page 35 of the "Draft Privileged ISA Specification v1.9" (https://riscv.org/specifications/privileged-isa/).

Tony Gutierrez Nov. 1, 2016, 8:39 a.m. (Nov. 1, 2016, 8:39 a.m.)

Thanks for the clarification, could you add a comment to the source to this effect?

src/arch/riscv/faults.hh (Diff revision 11)

Public/private should be indented 2 spaces. Fix throughout.

Show all issues

Description:

~		Changeset 11688:f84b3613acf4
	~	Changeset 11688:ccda87b39fe5

		arch: [Patch 1/5] Added RISC-V base instruction set RV64I

		First of five patches adding RISC-V to GEM5. This patch introduces the
		base 64-bit ISA (RV64I) in src/arch/riscv for use with syscall emulation.
		The multiply, floating point, and atomic memory instructions will be added
		in additional patches, as well as support for more detailed CPU models.
		The loader is also modified to be able to parse RISC-V ELF files, and a
		"Hello world!" example for RISC-V is added to test-progs.

		Patch 2 will implement the multiply extension, RV64M; patch 3 will implement
		the floating point (single- and double-precision) extensions, RV64FD;
		patch 4 will implement the atomic memory instructions, RV64A, and patch 5
		will add support for timing, minor, and detailed CPU models that is missing
		from the first four patches (such as handling locked memory).

		[Removed several unused parameters and imports from RiscvInterrupts.py,
		RiscvISA.py, and RiscvSystem.py.]
		[Fixed copyright information in RISC-V files copied from elsewhere that had
		ARM licenses attached.]
		[Reorganized instruction definitions in decoder.isa so that they are sorted
		by opcode in preparation for the addition of ISA extensions M, A, F, D.]
		[Fixed formatting of several files, removed some variables and
		instructions that were missed when moving them to other patches, fixed
		RISC-V Foundation copyright attribution, and fixed history of files
		copied from other architectures using hg copy.]
		[Fixed indentation of switch cases in isa.cc.]
		[Reorganized syscall descriptions in linux/process.cc to remove large
		number of repeated unimplemented system calls and added implmementations
		to functions that have received them since it process.cc was first
		created.]
		[Fixed spacing for some copyright attributions.]
		[Replaced the rest of the file copies using hg copy.]
		[Fixed style check errors and corrected unaligned memory accesses.]
	+	[Fix some minor formatting mistakes.]
		Signed-off by: Alec Roelke

Diff:

Revision 12 (+5980 -1)

Show changes

	build_opts/RISCV
	ext/libelf/elf_common.h
	src/arch/riscv/RiscvISA.py
	src/arch/riscv/RiscvInterrupts.py
	src/arch/riscv/RiscvSystem.py
	src/arch/riscv/RiscvTLB.py
	src/arch/riscv/SConscript
	src/arch/riscv/SConsopts
	52 more

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 11620:80e562ddf946

Changeset 11620:849620cf01a3

Diff:

Description:

Changeset 11620:849620cf01a3

Changeset 11620:01bf9539be09

Diff:

Description:

Changeset 11620:01bf9539be09

Changeset 11620:cceb2cc47bdd

Diff:

Description:

Changeset 11620:cceb2cc47bdd

Changeset 11620:3da42ffa5b4b

Diff:

Description:

Changeset 11620:3da42ffa5b4b

Changeset 11655:d0ecf8ecc940

Diff:

Description:

Changeset 11655:d0ecf8ecc940

Changeset 11655:d4aaaa876749

Diff:

Description:

Changeset 11655:d4aaaa876749

Changeset 11655:01b1d852e62e

Diff:

Description:

Changeset 11655:01b1d852e62e

Changeset 11655:e462a5c2cca2

Diff:

Description:

Changeset 11655:e462a5c2cca2

Changeset 11655:fce68047f694

Diff:

Description:

Changeset 11655:fce68047f694

Changeset 11688:f84b3613acf4

Diff:

Description:

Changeset 11688:f84b3613acf4

Changeset 11688:ccda87b39fe5

Diff:

Status: Closed (submitted)