Andreas Hansson got review request #3663!
config: Make configs/common a Python package
Review Request #3663 - Created Oct. 13, 2016 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11681:a9f0fce013bb --------------------------- config: Make configs/common a Python package Continue along the same line as the recent patch that made the Ruby-related config scripts Python packages and make also the configs/common directory a package. All affected config scripts are updated (hopefully). Note that this change makes it apparent that the current organisation and naming of the config directory and its subdirectories is rather chaotic. We mix scripts that are directly invoked with scripts that merely contain convenience functions. While it is not addressed in this patch we should follow up with a re-organisation of the config structure, and renaming of some of the packages.
I noticed one small thing, no need to repost.
Thanks for doing this. I agree that the whole configs directory needs some major re-working. I think most of it should be rewritten. There is no reason for us to have a single FSConfig.py file to define all possible full system options for all of the possible ISA/OS combinations. These scripts could all be much more modular / follow object-oriented design patterns. I'll put this on the list of things that we could do at the sprint at HPCA :).
-
configs/learning_gem5/part1/two_level.py (Diff revision 1) -
Should this be
../../?
Ship It!
Ship It!
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+138 -119) |