syscall_emul: [patch 8/22] refactor process class
Review Request #3674 - Created Oct. 17, 2016 and submitted
| Information | |
|---|---|
| Brandon Potter | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11696:c48d378a972a --------------------------- syscall_emul: [patch 8/22] refactor process class Moves aux_vector into its own .hh and .cc files just to get it out of the already crowded Process files. Arguably, it could stay there, but it's probably better just to move it and give it files. The changeset looks ugly around the Process header file, but the goal here is to move methods and members around so that they're not defined randomly throughout the entire header file. I expect this is likely one of the reasons why I several unused variables related to this class. So, the methods are declared first followed by members. I've tried to aggregate them together so that similar entries reside near one another. There are other changes coming to this code so this is by no means the final product.
Ship It!
Posted (Oct. 19, 2016, 11:23 a.m.)
-
src/sim/aux_vector.hh (Diff revision 1) -
In general, if you're creating a new file that contains pre-existing code from another file, the new file should inherit the original file's copyright and author list. Those apply to the code itself, and not the file as an entity. If you make changes or additions, you can then add the AMD 2016 copyright and your name to the author list. What you have here though makes it look like you wrote this code yourself from scratch in 2016, which is not right. I believe this applies in some of your other patches as well, though I neglected to flag it there.
-
src/sim/aux_vector.cc (Diff revision 1) -
why do we need to include process.hh here?