syscall_emul: [patch 14/22] adds identifier system calls
Review Request #3681 - Created Nov. 7, 2016 and submitted
Information | |
---|---|
Brandon Potter | |
gem5 | |
default | |
Reviewers | |
Default | |
Changeset 11721:351ac0e2863f --------------------------- syscall_emul: [patch 14/22] adds identifier system calls This changeset add fields to the process object and adds the following three system calls: setpgid, gettid, getpid.
-
src/sim/process.cc (Diff revision 1) -
This should be a fatal.
In fact, maybe 2. One to check that it's less than MAX_PID, and another to make sure it's not already in use.
-
src/sim/system.hh (Diff revision 1) -
Can this just be an std::set<int>? This is only used to make sure there are no duplicates, right?
-
src/sim/syscall_emul.cc (Diff revision 1) -
Use nullptr throughout.
Minor issue, otherwise it LGTM, assuming you address Jason's comments as well.
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+73 -11) |
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+72 -11) |
Ship It!
Thanks for the change!
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+72 -11) |