alpha: Remove ALPHA tru64 support and associated tests
Review Request #3688 - Created Oct. 27, 2016 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11705:6c2b4e24accf --------------------------- alpha: Remove ALPHA tru64 support and associated tests No one appears to be using it, and it is causing build issues and increases the development and maintenance effort.
I don't want this particular part to stall due to the larger discussion around: http://reviews.gem5.org/r/3684/. It the tru64 removal is fine with everyone we can proceed with this patch and I'll rebase the complete removal for further discussion.
-
src/arch/alpha/kernel_stats.cc (Diff revision 1) -
Could someone skilled in the arts help out with this?
Due to this removal, a number of Linux Tsunami regressions now have missing/removed stats.
Was the intention that these syscalls are both for linux and tru64? If so, they should be moved or re-added.
Please let me know asap.
-
src/arch/alpha/kernel_stats.cc (Diff revision 1) -
I think that Linux and Tru64 use the same PALCode, so it's possible that some of the Tru64 syscalls are reused in Linux? Maybe they should be readded but instead moved into the Linux OS code? Although it would be good if somebody with better knowledge of Alpha/Tru64 could comment on this.
-
src/arch/alpha/kernel_stats.cc (Diff revision 1) -
Both Linux and Tru64 use the same callpal to trigger a system call.
-
src/arch/alpha/kernel_stats.cc (Diff revision 1) -
I think that all that the stats do is record mode switches between user and kernel space. There's a small tracker for kvm switches in arm, but this doesn't look like very useful information outside of someone needing it for a publication. At least, it's not useful enough to implement for other architectures apparently. The other architectures only have stubs for this class: src/arch/*/kernel_stats.hh.
Instead of worrying about the maintenance, can we remove this and stop tracking the kernel stats altogether? (If it is deemed useful, it probably needs to be implemented for the other architectures too.)
Ship It!