syscall_emul: [PATCH 21/22] rewrite code related to system call exits
Review Request #3702 - Created Nov. 7, 2016 and submitted
Information | |
---|---|
Brandon Potter | |
gem5 | |
default | |
Reviewers | |
Default | |
Changeset 11730:9ee83d124c9c --------------------------- syscall_emul: [PATCH 21/22] rewrite code related to system call exits The changeset refactors exit, exit_group, and futex related exit functionality.
-
src/sim/futex_map.hh (Diff revision 1) -
This is not the license we should be using. See the gpu-compute code for our license.
-
src/sim/futex_map.hh (Diff revision 1) -
This comment needs more detail.
-
src/sim/futex_map.hh (Diff revision 1) -
Newline after the return type.
-
src/sim/se_signal.cc (Diff revision 1) -
Should this not be 2014, 2016?
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+293 -121) |
-
src/sim/futex_map.hh (Diff revision 2) -
I'm not sure if this is needed.
-
src/sim/futex_map.hh (Diff revision 2) -
Why not something simple, like:
return std::hash(addr) ^ (std::hash(tgid) << 1)
-
src/sim/system.hh (Diff revision 2) -
spurious whitespace change
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+285 -119) |
Ship It!
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+280 -113) |
Ship It!