Review Board 2.0.15

hsail: remove the panic guarding function directives

Review Request #3712 - Created Nov. 17, 2016 and submitted

Brandon Potter
Changeset 11705:3dbaf4ac9c81
hsail: remove the panic guarding function directives

HSA functions calls are still not supported properly with HSAIL, but
the recent AMP runtime modifications rely on being able to parse the
BRIG/HSAIL files that are extracted from the application binaries.
We need to parse the function call HSAIL definitions, but we do not
actually need to make the function calls.

The reason that this happens is that HCC appends a set of routines
to every HSAIL binary that it creates. These extra, unnecessary
routines exist in the HCC source as a file; this file is cat'd onto
everything that the compiler outputs before being assembled into the
application's binary. HCC does this because it might call these helper
functions. However, it doesn't actually appear to do so in the AMP
codes so we just parse these functions with the HSAIL parser and
then ignore them.

Review request changed
Updated (Dec. 2, 2016, 3:10 p.m.)

Status: Closed (submitted)