commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
Review Request #3740 - Created Nov. 21, 2016 and submitted
| Information | |
|---|---|
| Rahul Thakur | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 11708:02ce0fdd4929
---------------------------
commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
Author: Rahul Thakur <rjthakur@google.com>
Date: Thu Oct 27 20:36:16 2016 -0700
mem: Refactor CommMonitor stats, add basic atomic mode stats
Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b
Ship It!
-
src/mem/comm_monitor.hh (Diff revision 1) -
I think this should be:
Copyright [1]
Copyright [2]
All rights reservedAlso, if you do not need the first paragraph (which is not vanilla 3-clause BSD), I would suggest to move the Google Inc copyright so that it appears after the first paragraph, and only applying to the following two paragraphs.
If you do move it, please keep the All rights reserved as is. Also check the other patch concerning the license.
Looks good, thanks for fixing! You might want to consider the comments below before pushing the change.
-
src/mem/comm_monitor.cc (Diff revision 1) -
This condition seems redunant since you check the same thing in the MonitorStats class. In fact, it might be a bit confusing if someone descides to extend the stat class in the future.
-
src/mem/comm_monitor.cc (Diff revision 1) -
See above.
Description: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+134 -126) |
Ship It!