riscv: Remove ECALL tests from insttest
Review Request #3781 - Created Jan. 12, 2017 and submitted
Information | |
---|---|
Alec Roelke | |
gem5 | |
default | |
Reviewers | |
Default | |
Changeset 11808:1c38f8e541ba --------------------------- riscv: Remove ECALL tests from insttest The system calls tested in rv64i.cpp in RISC-V's insttest suite have different behavior depending on the operating system and file system they are run on. This patch ignores the output of those tests and only ensures that the instructions in RV64I complete successfully. [Change deletion of ECALL test to block comment.] [Restore ECALL test but remove test output to test only for completion without error.] [Update patch description and again try to push EMPTY files for rv64i tests.]
-
tests/test-progs/insttest/src/riscv/rv64i.cpp (Diff revision 1) -
Can you block-comment instead of delete? I think we'll want to add this back in sometime in the relatively near future (e.g., when we have functional-only tests).
Description: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1562 -1616) |
Another option is to remove the stats.txt from the stats results directory. This will turn the test into a functional-only test.
In fact that may be there better option here as we also don't have to worry about distributing a new binary.
Ship It!
Did you remove all files from the reference output directory? In that case, you'll need to add a an empty placeholder file called EMPTY in the reference directories. Some VCS systems (git being one of them) don't track empty directories, which would interfere with test discovery.
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (-9178)
|
Ship It!
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (-9178)
|