Review Board 2.0.15


style: Force Python.h to be included before main header

Review Request #3794 - Created Jan. 27, 2017 and submitted

Information
Andreas Sandberg
gem5
default
Reviewers
Default

Changeset 11803:1dba09aeeefd
---------------------------
style: Force Python.h to be included before main header

Python's header files set various compiler macros (e.g.,
_XOPEN_SOURCE) unconditionally. This triggers preprocessor warnings
that end up being treated as errors. The style guide used to mandate
that Python headers are included before any other header. This
requirement was changed to always include a source file's main header
first, which ended up triggering these errors.

This change updates the style checker to always include Python.h
before the main header file.

Change-Id: Id6a4f7fc64a336a8fd26691a0ca682abeb1d1579
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>


   
Review request changed
Updated (Feb. 7, 2017, 7:29 a.m.)

Status: Closed (submitted)