gpu-compute: Fix Python/C++ object hierarchy discrepancies
Review Request #3824 - Created Feb. 21, 2017 and discarded
Changeset 11878:b0a4f3815b55 --------------------------- gpu-compute: Fix Python/C++ object hierarchy discrepancies The GPUCoalescer and the Shader classes have different base classes in C++ and Python. This causes subtle bugs in SWIG and compilation errors for PyBind. Change-Id: I1ddd2a8ea43f083470538ddfea891347b21d14d8 Reviewed-by: Andreas Hansson <email@example.com>
Revision 2 (+17 -8)
Thanks for catching this bug. I'm now a bit surprised this code work correctly before.
I have a couple questions/comments below. The most important is possibly missing "max_outstanding_request" line. Other than that, this patch looks good to me and points out we have more items to fix.
This patch points out that we really should not have an icache or IFETCHes as part of the GPUCoalescer. It is designed to only handle data accesses from the GPU CUs.
You don't necessarily need to remove this line and make all the other necessary changes, but if you don't, we'll get someone from AMD to make that change.
Aren't you missing the following line:
max_outstanding_requests = Param.Int(16,
"max requests (incl. prefetches) outstanding")