Posted (Jan. 6, 2011, 9:59 p.m.)
-
src/dev/x86/i82094aa.hh (Diff revision 1) -
You don't need "virtual" here.
-
src/dev/x86/i82094aa.cc (Diff revision 1) -
This comment probably could go in /* */s. If you want to stick with //s, please get rid of the blank lines that are commented.
-
src/dev/x86/intdev.hh (Diff revision 1) -
I really want one of the folks that knows the memory system better (Steve, Ali, Nate) to comment on whether this is right. I'm worried that by only broadcasting its address range only at init it won't go out at all sometimes (checkpoint restore?) or somebody will miss somebody else's status change.
Posted (Jan. 9, 2011, 10:23 a.m.)
-
src/dev/x86/intdev.hh (Diff revision 1) -
I think this is correct. It should be fine, but checking with the chekpoint verifier script would be good before committing.