Review Board 2.0.15


m5: added work completed monitoring support

Review Request #398 - Created Jan. 6, 2011 and submitted

Information
Brad Beckmann
gem5
Reviewers
Default
ali, gblack, nate, stever 
m5: added work completed monitoring support

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Gabe Black

   
Posted  (Jan. 6, 2011, 10:13 p.m.)


  


  


  

   
What are these new pseudo instructions and script options for? I don't remember these being mentioned before. You should NOT check in the m5.disableAllListeners() line.



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    This patch tracks work items for those benchmarks that have had their work items annotated.  The disableAllListeners line should not have been included.  Sorry about that.
    
    
    
   
    2. 

   


  




   







    

     
     

      

       
        

         
          configs/common/Options.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
What are these for? Their descriptions aren't very helpful. If they only do something for x86 it seems wrong that they're displayed for every ISA.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    The are not x86 specific at all.  They can be used by any workload/ISA combination.
    
    
    
   
    2. 

   


  


    


    

     
     

      

       
        

         
          configs/example/fs.py
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
This line should -NOT- be checked in.




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/sim/system.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Member variables use camelCase, not underscores. What is active_cpus tracking? Don't we already have an idea of CPUs being active or quiesced?




  

   

   
    
    
   


  


    


    

     
     

      

       
        

         
          src/sim/system.hh
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
function name goes on the start of the next line.