diff -r 9be8a40026df -r 02553e77fa45 configs/common/Caches.py --- a/configs/common/Caches.py Mon Jul 20 09:15:18 2015 -0500 +++ b/configs/common/Caches.py Thu Jan 21 18:07:22 2016 +0000 @@ -76,7 +76,6 @@ mshrs = 20 size = '1kB' tgts_per_mshr = 12 - forward_snoops = False class PageTableWalkerCache(Cache): assoc = 2 @@ -85,7 +84,7 @@ mshrs = 10 size = '1kB' tgts_per_mshr = 12 - forward_snoops = False + # the x86 table walker actually writes to the table-walker cache if buildEnv['TARGET_ISA'] == 'x86': is_read_only = False diff -r 9be8a40026df -r 02553e77fa45 src/mem/cache/base.hh --- a/src/mem/cache/base.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/mem/cache/base.hh Thu Jan 21 18:07:22 2016 +0000 @@ -302,7 +302,7 @@ const int numTarget; /** Do we forward snoops from mem side port through to cpu side port? */ - const bool forwardSnoops; + bool forwardSnoops; /** * Is this cache read only, for example the instruction cache, or diff -r 9be8a40026df -r 02553e77fa45 src/mem/cache/base.cc --- a/src/mem/cache/base.cc Mon Jul 20 09:15:18 2015 -0500 +++ b/src/mem/cache/base.cc Thu Jan 21 18:07:22 2016 +0000 @@ -77,7 +77,7 @@ fillLatency(p->response_latency), responseLatency(p->response_latency), numTarget(p->tgts_per_mshr), - forwardSnoops(p->forward_snoops), + forwardSnoops(true), isReadOnly(p->is_read_only), blocked(0), order(0), @@ -86,6 +86,8 @@ addrRanges(p->addr_ranges.begin(), p->addr_ranges.end()), system(p->system) { + // forward snoops is overridden in init() once we can query + // whether the connected master is actually snooping or not } void @@ -131,6 +133,7 @@ if (!cpuSidePort->isConnected() || !memSidePort->isConnected()) fatal("Cache ports on %s are not connected\n", name()); cpuSidePort->sendRangeChange(); + forwardSnoops = cpuSidePort->isSnooping(); } BaseMasterPort & diff -r 9be8a40026df -r 02553e77fa45 src/cpu/simple/timing.hh --- a/src/cpu/simple/timing.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/cpu/simple/timing.hh Thu Jan 21 18:07:22 2016 +0000 @@ -164,11 +164,6 @@ protected: - /** - * Snooping a coherence request, do nothing. - */ - virtual void recvTimingSnoopReq(PacketPtr pkt) {} - TimingSimpleCPU* cpu; struct TickEvent : public Event diff -r 9be8a40026df -r 02553e77fa45 src/mem/cache/Cache.py --- a/src/mem/cache/Cache.py Mon Jul 20 09:15:18 2015 -0500 +++ b/src/mem/cache/Cache.py Thu Jan 21 18:07:22 2016 +0000 @@ -64,8 +64,6 @@ tgts_per_mshr = Param.Unsigned("Max number of accesses per MSHR") write_buffers = Param.Unsigned(8, "Number of write buffers") - forward_snoops = Param.Bool(True, - "Forward snoops from mem side to cpu side") is_read_only = Param.Bool(False, "Is this cache read only (e.g. inst)") prefetcher = Param.BasePrefetcher(NULL,"Prefetcher attached to cache") diff -r 9be8a40026df -r 02553e77fa45 src/cpu/o3/cpu.hh --- a/src/cpu/o3/cpu.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/cpu/o3/cpu.hh Thu Jan 21 18:07:22 2016 +0000 @@ -147,7 +147,6 @@ /** Timing version of receive. Handles setting fetch to the * proper status to start fetching. */ virtual bool recvTimingResp(PacketPtr pkt); - virtual void recvTimingSnoopReq(PacketPtr pkt) { } /** Handles doing a retry of a failed fetch. */ virtual void recvReqRetry(); diff -r 9be8a40026df -r 02553e77fa45 src/cpu/simple/atomic.hh --- a/src/cpu/simple/atomic.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/cpu/simple/atomic.hh Thu Jan 21 18:07:22 2016 +0000 @@ -127,7 +127,6 @@ { } protected: - virtual Tick recvAtomicSnoop(PacketPtr pkt) { return 0; } bool recvTimingResp(PacketPtr pkt) { diff -r 9be8a40026df -r 02553e77fa45 src/cpu/minor/cpu.hh --- a/src/cpu/minor/cpu.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/cpu/minor/cpu.hh Thu Jan 21 18:07:22 2016 +0000 @@ -107,9 +107,6 @@ : MasterPort(name_, &cpu_), cpu(cpu_) { } - protected: - /** Snooping a coherence request, do nothing. */ - virtual void recvTimingSnoopReq(PacketPtr pkt) { } }; protected: diff -r 9be8a40026df -r 02553e77fa45 src/cpu/minor/lsq.hh --- a/src/cpu/minor/lsq.hh Mon Jul 20 09:15:18 2015 -0500 +++ b/src/cpu/minor/lsq.hh Thu Jan 21 18:07:22 2016 +0000 @@ -103,8 +103,12 @@ void recvReqRetry() { lsq.recvReqRetry(); } + bool isSnooping() const override { return true; } + void recvTimingSnoopReq(PacketPtr pkt) { return lsq.recvTimingSnoopReq(pkt); } + + void recvFunctionalSnoop(PacketPtr pkt) { } }; DcachePort dcachePort; diff -r 9be8a40026df -r 02553e77fa45 configs/common/O3_ARM_v7a.py --- a/configs/common/O3_ARM_v7a.py Mon Jul 20 09:15:18 2015 -0500 +++ b/configs/common/O3_ARM_v7a.py Thu Jan 21 18:07:22 2016 +0000 @@ -149,7 +149,6 @@ tgts_per_mshr = 8 size = '32kB' assoc = 2 - forward_snoops = False is_read_only = True # Writeback clean lines as well writeback_clean = True @@ -176,7 +175,6 @@ size = '1kB' assoc = 8 write_buffers = 16 - forward_snoops = False is_read_only = True # Writeback clean lines as well writeback_clean = True