Review Board 2.0.15

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Information
Submitter:	Brandon Potter
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 11728:85a344df47dd
---------------------------
syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

Testing Done

Issue Summary

Description	From	Last Updated	Status
Not the correct license.	Tony Gutierrez	Nov. 14, 2016, 10:52 a.m.	Resolved
LiveProcess is gone now, right?	Michael LeBeane	Nov. 16, 2016, 8:36 a.m.	Resolved
This should not have an underscore, also why not just use signal?	Alexandru Dutu	Jan. 23, 2017, 11:04 a.m.	Resolved

src/sim/se_signal.hh (Diff revision 1)

Not the correct license.

Show all issues

Description:

~		Changeset 11708:6a7a3eee7cd0
	~	Changeset 11726:a99acbcd61b4

		syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

Diff:

Revision 2 (+106)

	src/sim/SConscript
	src/sim/se_signal.hh
	src/sim/se_signal.cc
	src/sim/system.hh

Where is this used?

src/sim/se_signal.hh (Diff revision 2)

LiveProcess is gone now, right?

Show all issues

Brandon Potter Nov. 16, 2016, 8:40 a.m. (Nov. 16, 2016, 8:40 a.m.)

I'd originally fixed this in http://reviews.gem5.org/r/3702/. I moved the changes into this patch (and also updated 3702).

Description:

~		Changeset 11726:a99acbcd61b4
	~	Changeset 11728:85a344df47dd

		syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

Diff:

Revision 3 (+105)

	src/sim/SConscript
	src/sim/se_signal.hh
	src/sim/se_signal.cc
	src/sim/system.hh

src/sim/se_signal.hh (Diff revision 3)

This should not have an underscore, also why not just use signal?

Show all issues

Status: Closed (submitted)