ruby: Resurrected Ruby's deterministic tests
Review Request #101 - Created Aug. 5, 2010 and submitted
| Information | |
|---|---|
| Brad Beckmann | |
| gem5 | |
| Reviewers | |
| Default | |
ruby: Resurrected Ruby's deterministic tests Added the request series and invalidate deterministic tests as new cpu models and removed the no longer needed ruby tests
Posted (Aug. 8, 2010, 1:48 p.m.)
I think the directory name needs to have tester in it. src/cpu/deterministic gives you no indication of what it actually is. Beyond that, is it really necessary to have multiple testers? Can we not fold the functionality into a single tester?
-
src/cpu/deterministic/DetermGenerator.hh (Diff revision 1) -
These include guards need to be fixed.
-
src/cpu/deterministic/DetermGenerator.hh (Diff revision 1) -
Sort includes please.
-
src/cpu/deterministic/DetermGenerator.hh (Diff revision 1) -
All of the comments in this file are pretty obvious and should probably be deleted.
-
src/cpu/deterministic/DetermGenerator.hh (Diff revision 1) -
For new files, can you please follow the M5 style for variable names? no m_ and camelCase.
-
src/cpu/deterministic/InvalidateGenerator.hh (Diff revision 1) -
Fix include guards
-
src/cpu/deterministic/InvalidateGenerator.hh (Diff revision 1) -
Useless comments.
-
src/cpu/deterministic/InvalidateGenerator.cc (Diff revision 1) -
You don't need to change this if you don't want to, but for your education, you could simply collapse this line and the next into: uint8_t *dummyData = new uint8_t(0);
-
src/cpu/deterministic/RubyDetermTester.cc (Diff revision 1) -
Please just delete this comment.
-
src/cpu/deterministic/SeriesRequestGenerator.hh (Diff revision 1) -
Fix include guards.
-
src/cpu/deterministic/SeriesRequestGenerator.hh (Diff revision 1) -
useless comments
-
src/cpu/deterministic/SeriesRequestGenerator.hh (Diff revision 1) -
Fix variable names.
Review request changed
Updated (Aug. 11, 2010, 5:01 a.m.)
Review request changed
Updated (Aug. 11, 2010, 7:34 a.m.)
Diff: |
Revision 3 (+971 -898)
|
|---|
