prefetcher: Make prefetcher a sim object instead of it being a parameter on cache
Review Request #1011 - Created Jan. 25, 2012 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
prefetcher: Make prefetcher a sim object instead of it being a parameter on cache
Issue Summary
9
1
8
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Is setCache necessary or can we do this in the constructor? | Andreas Hansson | Jan. 25, 2012, 10:14 p.m. | Open |
Posted (Jan. 25, 2012, 10:14 p.m.)
Any testing done?
-
src/mem/cache/prefetch/base.hh (Diff revision 1) -
Tick and unsigned int rather than int, or is there a reason to ever have negative values?
-
src/mem/cache/prefetch/base.hh (Diff revision 1) -
Is setCache necessary or can we do this in the constructor?
-
src/mem/cache/prefetch/ghb.cc (Diff revision 1) -
whitespace?
-
src/mem/cache/prefetch/stride.cc (Diff revision 1) -
whitespace?
Posted (Feb. 7, 2012, 3:55 a.m.)
Anyone have any final comments?
Posted (Feb. 7, 2012, 4:28 a.m.)
-
src/mem/cache/prefetch/Prefetcher.py (Diff revision 1) -
Can we take this opportunity to remove the 'prefetch(er)_' prefixes from these param names? The original purpose was to distinguish them among the cache params, but that's not necessary anymore, and now it's just redundant and verbose.
-
src/mem/cache/prefetch/base.hh (Diff revision 1) -
How about some comments here?
-
src/mem/cache/prefetch/ghb.hh (Diff revision 1) -
Shouldn't these be removed since they're in the base class now?
-
src/mem/cache/prefetch/tagged.hh (Diff revision 1) -
Same here.
-
src/mem/cache/prefetch/tagged.cc (Diff revision 1) -
These initializations should be in the base constructor too.
