Fix switching of CPUs

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 8859:7e91ef576149
---------------------------
Fix switching of CPUs
This patch prevents creation of interrupt controller for
cpus that will be switched in later

Testing Done

Ship It!

I'd like to see a check in cpu/base.cc to ensure that the interrupts are really set properly. Currently it seems that failing to call createInterrupts would result in a segfault.

Nilay Vaish Feb. 29, 2012, 12:19 a.m. (Feb. 29, 2012, 12:19 a.m.)

There is a check on line 224. I can add assert in the takeOver function.

Andreas Hansson Feb. 29, 2012, 12:53 a.m. (Feb. 29, 2012, 12:53 a.m.)
```
I was thinking: if not deferred, make sure interrupt is not NULL.
```

Nilay Vaish Feb. 29, 2012, 12:59 a.m. (Feb. 29, 2012, 12:59 a.m.)

Would deferred registration be set to true for the checker CPU? I doubt that.

Andreas Hansson Feb. 29, 2012, 1:02 a.m. (Feb. 29, 2012, 1:02 a.m.)

No no, I'm just saying, for a CPU that is not switched in later, i.e. up and running from time 0, make sure it actually has an interrupt controller (that someone called createInterrupts).

Nilay Vaish Feb. 29, 2012, 2:17 a.m. (Feb. 29, 2012, 2:17 a.m.)

I think it is not possible to put in such a check. Again, the checker CPU, even though would be running 
right from the beginning, would not have the interrupt controller.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)