IGbE: Fix writeback conditions for i8254x GbE in updated data sheet
Review Request #1077 - Created March 3, 2012 and submitted
| Information | |
|---|---|
| Pritha Ghoshal | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8849:a9de774c9d02 --------------------------- IGbE: Fix writeback conditions for i8254x GbE in updated data sheet. An older revision of the data sheet specified that txdctl.gran was 1 the granularity was based on cache block and gran being 0 is based on descriptor count. The newer version of the data sheet reverses this errata
Tested by running benchmark NetperfStream.
Posted (March 3, 2012, 4:51 a.m.)
Looks great? Have you tested it? I assume it works? Our commit messages are supposed to be of the format: <one word>: <summary> <detail> Could you change it to something like: IGbE: Fix writeback conditions for i8254x GbE in updated data sheet. An older revision of the data sheet specified that txdctl.gran was 1 the granularity was based on cache block and gran being 0 is based on descriptor count. The newer version of the data sheet reverses this errata.
-
src/dev/i8254xGBe.cc (Diff revision 1) -
Could you remove the == 0 and just use a !?
Review request changed
Updated (March 3, 2012, 10:05 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+2 -2) |
Review request changed
Updated (March 3, 2012, 10:08 a.m.)
Change Summary:
Modified testing field and description field. Also updated the changelist as suggested by Ali.
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
Review request changed
Updated (March 3, 2012, 10:09 a.m.)
Summary: |
|
|---|
Ship It!
Posted (May 27, 2012, 2:54 p.m.)
Pritha, please mark this patch as committed.