src/SConscript (Diff revision 1)

I don't want to claim that this won't work, but what happens if somebody has a build target that isn't one of the main binaries? Occasionally (very) I've built one of the targets of the ISA parser explicitly to focus on just that bit. What would happen then?

Show all issues

Hi Marc. Looks great, but I too have a concern like Gabe mentioned. Not so much in his usecase, but what happens if you try to build one of the unittest binaries or a regression test target (that implicitly depends on a binary)?

Otherwise looks great.
Thanks for all the effort.
Ali

Perhaps a better solution is to iterate through BUILD_TARGETS and try to identify for each one which environment it needs (e.g., looking for a suffix like '.debug' or '.do', or 'tests/debug' in the path), and if these heuristics fail then just fall back on including them all.

src/SConscript (Diff revision 1)

Similarly to Gabe's point, I sometimes use scons to drive individual tests, like:
  scons build/ALPHA/tests/debug/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing
so the -3 index isn't a given here either.

Show all issues

looks good to me.

Other than the extra blank line and making sure you get the right commit message (somehow you lost it in the update), this looks great to me.  Thanks!

src/SConscript (Diff revision 2)

Looks like you have a spurious blank line here.

Ship It!